[PATCH] D102560: [AIX][clang-repl][test] Mark unsupported pending XCOFF64 integrated-as

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 15 13:34:26 PDT 2021


hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: v.g.vassilev, lhames, daltenty, jasonliu, jsji.
Herald added a subscriber: steven.zhang.
hubert.reinterpretcast requested review of this revision.
Herald added a project: clang.

This patch replaces the `powerpc64` token with the `system-aix` one in the UNSUPPORTED line of a test. The `powerpc64` token was originally added temporarily in 71a0609a2b53 <https://reviews.llvm.org/rG71a0609a2b533dbcd6826ad774b6bee5e9818644>.

If AIX uses integrated-as by default and it works both for 32-bit and 64-bit objects, then the issues encountered so far (see comments in D96033 <https://reviews.llvm.org/D96033>) would be mostly solved.

As it is, marking the test as expected-to-fail (as opposed to unsupported) on AIX might cause more trouble in the form of 32-bit versus 64-bit differences. I am not aware of other situations where LIT tests are dependent on whether the LLVM build is 64-bit or 32-bit.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102560

Files:
  clang/test/Interpreter/execute.cpp


Index: clang/test/Interpreter/execute.cpp
===================================================================
--- clang/test/Interpreter/execute.cpp
+++ clang/test/Interpreter/execute.cpp
@@ -1,6 +1,6 @@
 // RUN: cat %s | clang-repl | FileCheck %s
 // REQUIRES: host-supports-jit
-// UNSUPPORTED: powerpc64
+// UNSUPPORTED: system-aix
 
 extern "C" int printf(const char *, ...);
 int i = 42;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102560.345649.patch
Type: text/x-patch
Size: 393 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210515/09d01320/attachment.bin>


More information about the cfe-commits mailing list