[PATCH] D102558: [Utils] Check for generated functions inline if possible

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 15 11:31:03 PDT 2021


jdoerfert created this revision.
jdoerfert added reviewers: greened, arichardson, ggeorgakoudis.
Herald added a subscriber: bollu.
jdoerfert requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1.
Herald added projects: clang, LLVM.

With D83004 <https://reviews.llvm.org/D83004> we allowed to check for generated functions. However, since
those might be generated in various places we did simply check for all
functions in the end. Furthermore, this prevented us from reusing check
prefixes across run lines. For every run line we checked for all functions
regardless if the functions were equal across prefixes.

To reduce the number of check lines we now allow to reuse them across
run lines. That is, we can have prefixes that span multiple run lines
even when we check for generated functions. This will only reduce the
run lines if we can find a total order of the generated functions
though. The check lines for generated functions are placed in-between
check lines of existing functions or at the end, as necessary.

The IR update script needs adjusts similar to the CC one.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102558

Files:
  clang/test/utils/update_cc_test_checks/Inputs/generated-funcs-regex.c.expected
  clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected
  clang/test/utils/update_cc_test_checks/Inputs/lots-of-generated-funcs.c
  clang/test/utils/update_cc_test_checks/Inputs/lots-of-generated-funcs.c.lots-of-generated.expected
  clang/test/utils/update_cc_test_checks/Inputs/lots-of-generated-funcs.c.no-lots-of-generated.expected
  clang/test/utils/update_cc_test_checks/lots-of-generated-funcs.test
  llvm/utils/UpdateTestChecks/common.py
  llvm/utils/update_cc_test_checks.py
  llvm/utils/update_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102558.345646.patch
Type: text/x-patch
Size: 33114 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210515/ea219b48/attachment-0001.bin>


More information about the cfe-commits mailing list