[PATCH] D102494: [Clang, Driver] Default to Darwin_libsystem_m veclib on iOS based targets.

[Steve Canon via Phabricator via cfe-commits]

scanon added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2492
+  // Darwin_libsystem_m for iOS based targets.
+  if (isTargetIOSBased() && !DriverArgs.hasArgNoClaim(options::OPT_fveclib))
+    CC1Args.push_back("-fveclib=Darwin_libsystem_m");
----------------
fhahn wrote:
> arphaman wrote:
> > Is this applicable to the watchOS targets as well? The iOS based check doesn't cover it.
> `libsystem_m`'s vector functions should be available on all Darwin platforms I think. I'd gradually opt-in additional platforms, once we verified it is clearly beneficial for each platform individually.
> 
> Should I add a TODO?
Correct, available on all Darwin systems. These APIs were introduced in macOS 10.13, iOS 11.0, watchOS 4.0, tvOS 11.0, and driverkit 19.0. I think we need a check that the target is at least those versions somewhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102494/new/

https://reviews.llvm.org/D102494