[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anton Zabaznov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 14 07:43:46 PDT 2021


azabaznov added inline comments.


================
Comment at: clang/lib/Sema/Sema.cpp:306
+    // Set conditionally to provide correct diagnostics for 'double' type
+    llvm::StringRef FP64Feature(
+        getLangOpts().OpenCLVersion >= 300 ? "__opencl_c_fp64" : "cl_khr_fp64");
----------------
Anastasia wrote:
> Technically both "__opencl_c_fp64" and "cl_khr_fp64" are required in OpenCL, perhaps we should report both in OpenCL 3?
Even better, can we merge this first https://reviews.llvm.org/D100976? This is needed to completely remove such check for fp64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96524/new/

https://reviews.llvm.org/D96524



More information about the cfe-commits mailing list