[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

Abbas Sabra via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 14 02:54:12 PDT 2021


AbbasSabra marked 2 inline comments as done.
AbbasSabra added a comment.

> Please, add these reviewers for your upcoming [analyzer] patches.

Thanks, I was planning to add reviewers after making sure that the pre-checks are green.

> Nice to see some fixes for visual c++ stuff.

Thanks for the quick review!



================
Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:352
 
+      case Stmt::SEHLeaveStmtClass:
       case Stmt::ContinueStmtClass:
----------------
steakhal wrote:
> You should probably extend the `ExprEngine.cpp:1312` in a similar fashion.
isn't it already handled in  !!ExprEngine.cpp:1239!!?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102280/new/

https://reviews.llvm.org/D102280



More information about the cfe-commits mailing list