[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 13 19:06:26 PDT 2021


phosek added inline comments.


================
Comment at: clang/include/clang/Basic/TargetCXXABI.h:69
+  // default.
+  static bool supportsRelativeCXXVTables(const llvm::Triple &T) {
+    return T.isOSFuchsia();
----------------
I think that `supports` here is a bit misleading, I'd expect the return value to signal whether relative vtables C++ ABI is supported or not but not control the default. Maybe `usesRelativeVTables`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102374/new/

https://reviews.llvm.org/D102374



More information about the cfe-commits mailing list