[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

Hongtao Yu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 13 16:02:32 PDT 2021


hoy added a comment.

In D102356#2758179 <https://reviews.llvm.org/D102356#2758179>, @dblaikie wrote:

> This was previously crashing, I guess? Testing should validate the behavior beyond the crash, though - (presumably there's some more specific behavior than "does not crash" that wasn't being tested for before - that certain names are mangled appropriately or what-have-you)

Yes, an assert was triggered related to c++ constructors/destructors while it's not now. Regarding the behavior, c++ constructors/destructors are not static, so I don't expect a behavior change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102356/new/

https://reviews.llvm.org/D102356



More information about the cfe-commits mailing list