[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

[Matt Morehouse via Phabricator via cfe-commits]

morehouse added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:4172
+// on x86_64 and is subject to change in the future.  For example, we may want
+// to distinguish between LAM48 and LAM57 at some point.
+def mlam : Flag<["-"], "mlam">, Group<m_x86_Features_Group>;
----------------
eugenis wrote:
> Hmm this might be a good argument to go with something else for now.
> What would -mlam actually affect, besides hwasan? Significant bits computation?
> 
> If we see LAM as future production mode for HWASan, and aliasing - more of a temporary, proof-of-concept thing, then how about -fexperimental-sanitize-hwaddress-aliasing flag?
> Hmm this might be a good argument to go with something else for now.
> What would -mlam actually affect, besides hwasan? Significant bits computation?

Not sure.  I could imagine at least defining a preprocessor guard for conditional compilation (similar to `-mavx`).

> 
> If we see LAM as future production mode for HWASan, and aliasing - more of a temporary, proof-of-concept thing, then how about -fexperimental-sanitize-hwaddress-aliasing flag?

Sounds good, done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102288/new/

https://reviews.llvm.org/D102288