[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

[Melanie Blower via Phabricator via cfe-commits]

mibintc added a comment.

In D101640#2757316 <https://reviews.llvm.org/D101640#2757316>, @aaron.ballman wrote:

> In D101640#2757178 <https://reviews.llvm.org/D101640#2757178>, @mibintc wrote:
>
>> In D101640#2757039 <https://reviews.llvm.org/D101640#2757039>, @aaron.ballman wrote:
>>
>>> Thanks! The last remaining question to me is whether this should be a target-specific option or whether it makes sense to allow it as an option for any target.
>>
>> I thought the patch may be more acceptable to the community if we restricted it.
>
> I think we usually prefer more general solutions to target-specific ones, typically. Given that the functionality is generally useful for easing porting projects from 32- to 64-bits and that the code is simpler without the target-specific bits, my preference is to go with the general solution unless someone else has objections.

Actually I thought about it some more and I don't know, generally, in what condition to enable the option. For example, on x86 we don't want any transformation made, and on intel64 we do want the implicit cast inserted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101640/new/

https://reviews.llvm.org/D101640