[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 13 09:28:52 PDT 2021


hubert.reinterpretcast added a comment.

In D96033#2757179 <https://reviews.llvm.org/D96033#2757179>, @v.g.vassilev wrote:

> In D96033#2757107 <https://reviews.llvm.org/D96033#2757107>, @v.g.vassilev wrote:
>
>> In D96033#2757077 <https://reviews.llvm.org/D96033#2757077>, @hubert.reinterpretcast wrote:
>>
>>> @v.g.vassilev, the test does not appear to be appropriately set up for builds that default to a non-native target:
>>> https://lab.llvm.org/staging/#/builders/126/builds/371/steps/5/logs/FAIL__Clang__execute_cpp
>>>
>>> Can you fix or revert until there is a fix?
>>
>> Apologies. Do you know if `REQUIRES: native` is sufficient to fix (trying to avoid churn)?

A speculative application of the above probably helps and would be harmless (I think).

> @lhames and I are working on a patch. We do not have easy access to such machines. Would you mind testing it on the bot?

I have a local build I can apply a patch to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96033/new/

https://reviews.llvm.org/D96033



More information about the cfe-commits mailing list