[PATCH] D102025: Thread safety analysis: Factor out function for merging locks (NFC)

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 13 05:22:34 PDT 2021


aaron.ballman added inline comments.


================
Comment at: clang/lib/Analysis/ThreadSafety.cpp:2199
+    // Take the exclusive capability to reduce further warnings.
+    return B.kind() == LK_Exclusive;
+  } else {
----------------
The old code was looking at `LDat1.kind() != LK_Exclusive` -- any reason this isn't `A.kind() != LK_Exclusive` as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102025/new/

https://reviews.llvm.org/D102025



More information about the cfe-commits mailing list