[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 12 19:49:39 PDT 2021


NoQ added a comment.

Additionally, `forCallable(functionDecl())` is not equivalent to `forFunction()` (the former silently matches less stuff). So anybody who had `functionDecl()` spelled out explicitly in their code will observe a silent change in behavior. I think that most of the time the difference was a footgun (i.e., most of the time when people wrote `forFunction()` they actually expected it to behave like `forCallable(functionDecl())`) but I can't be 100% sure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102213/new/

https://reviews.llvm.org/D102213



More information about the cfe-commits mailing list