[PATCH] D102251: Suppress Deferred Diagnostics in discarded statements.

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/include/clang/AST/EvaluatedExprVisitor.h:37
+  // 'constexpr-if'.
+  bool shouldVisitDiscardedCase() const { return true; }
 #define PTR(CLASS) typename Ptr<CLASS>::type
----------------
rsmith wrote:
> Maybe `shouldVisitDiscardedStmt` would be more obvious, since "discarded statement" is the standard terminology.
Yep, agreed.  I'll do that as a part of the commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102251/new/

https://reviews.llvm.org/D102251