[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

(Now completed the reply, see phab.)

In D98798#2754635 <https://reviews.llvm.org/D98798#2754635>, @xbolva00 wrote:

> You dont have to use -Wno-…
>
> You can use pragma to disable this warning for certain location in the code, eg include of commctrl.h.

commctrl.h is included by other system headers too though.

I don't think requiring users to add pragmas in all files that transitively include a random subset of windows headers is great :) I'm fine with not reverting if a fix for this will happen soon, but it sounds like the author is away for a few days. Reverts are cheap.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98798/new/

https://reviews.llvm.org/D98798