[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 12 08:06:54 PDT 2021


jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/deviceRTLs/common/generated_microtask_cases.gen:1
+case 0:
+((void (*)(kmp_int32 *, kmp_int32 *
----------------
JonChesterfield wrote:
> This is not very pretty. Why do we need runtime dispatch to a function pointer?
because we have variadic functions right now. A patch to remove this is already underway:
 https://reviews.llvm.org/D102107


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95976/new/

https://reviews.llvm.org/D95976



More information about the cfe-commits mailing list