[PATCH] D102261: Introduce SYCL 2020 mode

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In D102261#2751819 <https://reviews.llvm.org/D102261#2751819>, @tschuett wrote:

> But there is no SYCLMinorVersion today. So enum class SYCLVersion would suffice.

I don't think the presence of the word 'Major' in Aaron's suggestion is the most offensive to me.  While I think a good case can be made to make this just SYCLVersion (I don't think we have a minor version?), I think making this a scoped-enum is just going to end up with a worse experience.  `LangOptions::SYCL_2020` is equally as descriptive as `LangOptions::SYCLVersion::Ver2020`.  And I'd say is even MORE descriptive, since `Ver2020` has a very low information density.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102261/new/

https://reviews.llvm.org/D102261