[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 11 12:21:48 PDT 2021


MaskRay added inline comments.


================
Comment at: clang/tools/driver/cc1as_main.cpp:407
 
-  MOFI->initMCObjectFileInfo(Ctx, PIC);
+  // FIXME: This is not pretty. MCContext has a ptr to MCObjectFileInfo and
+  // MCObjectFileInfo needs a MCContext reference in order to initialize itself.
----------------
Can we fix the FIXME now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101921/new/

https://reviews.llvm.org/D101921



More information about the cfe-commits mailing list