[PATCH] D102261: Introduce SYCL 2020 mode

Tue May 11 11:59:09 PDT 2021

aaron.ballman added inline comments.

================
Comment at: clang/include/clang/Basic/LangOptions.h:130

   enum SYCLMajorVersion {
     SYCL_None,
----------------
tschuett wrote:
> Do you want to change  it to a scoped enum or will this cause major issues? ClangABI is a scoped enum?!?
Given that it's already scoped to `LangOptions`, I think a scoped enum adds more noise than anything. It'd make it awkward to name the actual enumerators due to using dates. I think we'd wind up needing to write `LangOptions::SYCLMajorVersion::Ver2017` (or something along those lines), which doesn't seem like a huge win to me. WDYT?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102261/new/

https://reviews.llvm.org/D102261