[PATCH] D102261: Introduce SYCL 2020 mode

Tue May 11 11:05:53 PDT 2021

aaron.ballman added inline comments.

================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:481
       Builder.defineMacro("CL_SYCL_LANGUAGE_VERSION", "121");
+      Builder.defineMacro("SYCL_LANGUAGE_VERSION", "201707");
+    } else if (LangOpts.getSYCLVersion() == LangOptions::SYCL_2020) {
----------------
erichkeane wrote:
> This seems very related, but perhaps a part of a different patch?  I think I'm probably OK bringing this in during this patch, but it isn't strictly related to adding 2020 support.
Oops, I'll remove that one, you're right that it's unrelated. Thanks!

================
Comment at: clang/test/Preprocessor/sycl-macro.cpp:13
 // CHECK-SYCL-STD:#define CL_SYCL_LANGUAGE_VERSION 121
+// CHECK-SYCL-STD:#define SYCL_LANGUAGE_VERSION 201707
+// CHECK-SYCL-STD-2020:#define SYCL_LANGUAGE_VERSION 202001
----------------
This change is unrelated as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102261/new/

https://reviews.llvm.org/D102261