[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

Tue May 11 05:36:44 PDT 2021

ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.

Nice, thanks!

In D102185#2749279 <https://reviews.llvm.org/D102185#2749279>, @steveire wrote:

> Adding Yitzhak as a reviewer. I notice that at least the name of a cxxBaseSpecifier is not supported and I don't know if that (or lack of typeloc support) is desired in the Transformer design.

No, not by design, but good question. I'd be happy to take a patch adding `cxxBaseSpecifier` support as well.

================
Comment at: clang/lib/Tooling/Transformer/RangeSelector.cpp:234
+      TypeLoc Loc = *T;
+      auto ET = T->getAs<ElaboratedTypeLoc>();
+      if (!ET.isNull()) {
----------------
Please use `Loc` instead of `T->`. I find it a bit confusing to see them both used.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102185/new/

https://reviews.llvm.org/D102185