[PATCH] D101914: [clangd][index-sever] Limit results in repsonse

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.

Good point, thanks!

I wonder if this can somehow make the experience worse in _some_ specific cases but I can't think of anything on top of my mind, so this should be all good.



================
Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:152
+    if (HasMore)
+      log("[public] Limiting result size for Lookup request.");
     LookupReply LastMessage;
----------------
nit (here and elsewhere): maybe add something like `(requested X, sending Y)` to the message for clarity. I don't expect this to be common anyway so probably verbosity isn't an issue here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101914/new/

https://reviews.llvm.org/D101914