[PATCH] D101735: [WebAssembly] Reenable end-to-end test in wasm-eh.cpp

Mon May 10 21:27:19 PDT 2021

dblaikie added a comment.

In D101735#2749716 <https://reviews.llvm.org/D101735#2749716>, @aheejin wrote:

> @dblaikie I can remove this one. This is not an important test anyway. But where are we supposed to test the arguments clang driver invokes the backend LLVM compilation with? This was mainly to test if `-exception-model=wasm` reaches the backend compilation.

Ah, and that flag is passed down through MCOptions or something like that (something purely in the programmatic API, not serialized into IR)? Fair enough - this is one of the exceptions to the "no end to end testing" rule - if it's the only way to demonstrate that the relevant MCOption was configured correctly, end-to-end testing is the best we've got there.

Thanks for the details!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101735/new/

https://reviews.llvm.org/D101735