[PATCH] D102159: [index][analyzer][ctu] Eliminate white spaces in the CTU lookup name.

Ella Ma via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 10 21:14:02 PDT 2021


OikawaKirie added a comment.

In D102159#2749033 <https://reviews.llvm.org/D102159#2749033>, @akyrtzi wrote:

> Maybe we could also handle this kind of type instead of leaving it 'unhandled'? What `Type` is it?

The member function pointer type, see the test case.

Although it would be perfect to handle this kind of type, I mean the white spaces should still be removed from the USR.
Currently, the white space character is used as the separator between the index string and the file path in the output of `clang-extdef-mapping`.
And it is difficult to determine when the index string with white space characters ends when parsing the output of `clang-extdef-mapping`.
Therefore, IMO the white space character had better not be used in the index string.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102159/new/

https://reviews.llvm.org/D102159



More information about the cfe-commits mailing list