[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

Mon May 10 18:45:19 PDT 2021

ChuanqiXu added a comment.

In D102147#2747939 <https://reviews.llvm.org/D102147#2747939>, @ychen wrote:

> In D102147#2747611 <https://reviews.llvm.org/D102147#2747611>, @ChuanqiXu wrote:
>
>> Since D97915 <https://reviews.llvm.org/D97915> would fix the problem that the variables in the frame may not be aligned, I think this option `fcoroutines-aligned-alloc` won't affect normal programmers other than language lawyers. Do you think so?
>
> I think that's right that if all a user want is alignment, then `fcoroutines-aligned-alloc` may not be necessary. However if they define customed aligned allocators/dealllocators, this is needed to make it work.

I see. The overall idea looks good. I would try to look into the details.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102147/new/

https://reviews.llvm.org/D102147