[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 10 18:45:06 PDT 2021


rsmith added inline comments.


================
Comment at: clang/lib/Interpreter/IncrementalParser.cpp:226-235
+  if (PP.getLangOpts().DelayedTemplateParsing) {
+    // Microsoft-specific:
+    // Late parsed templates can leave unswallowed "macro"-like tokens.
+    // They will seriously confuse the Parser when entering the next
+    // source file. So lex until we are EOF.
+    Token Tok;
+    do {
----------------
What are these tokens, exactly? Are we sure it's safe to discard them rather than parsing them?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96033/new/

https://reviews.llvm.org/D96033



More information about the cfe-commits mailing list