[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 10 13:48:20 PDT 2021


dblaikie added a comment.

Does this cause duplicate DW_TAG_reference_types in the output, if the input IR Has both DW_TAG_reference_type and DW_TAG_rvalue_reference_types?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:391
+  // version.
+  dwarf::Tag FixedTag = (dwarf::Tag)Tag;
+  if (Asm->TM.Options.DebugStrictDwarf &&
----------------
Rather than adding a cast here, perhaps the parameter type could be updated? (maybe in a separate preliminary commit, though, so as not to muddy this one)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100630/new/

https://reviews.llvm.org/D100630



More information about the cfe-commits mailing list