[PATCH] D102069: [clang][PreProcessor] Cutoff parsing after hitting completion point
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun May 9 23:47:43 PDT 2021
hokein added inline comments.
================
Comment at: clang/lib/Lex/PPDirectives.cpp:3026
const bool ConditionalTrue = DER.Conditional;
+ // Lexer might become invalid if we hit code completion point while evulating
+ // expression.
----------------
evulating => evaluating
IIUC, `CurPPLexer` may be reset to nullptr after the above `EvaluateDirectiveExpression` call? If so, I think there is another place having the same pattern, line 597 of this file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102069/new/
https://reviews.llvm.org/D102069
More information about the cfe-commits
mailing list