[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation
PoojaYadav via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun May 9 10:45:52 PDT 2021
pooja2299 updated this revision to Diff 343920.
pooja2299 added a comment.
Made some corrections
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102134/new/
https://reviews.llvm.org/D102134
Files:
clang/include/clang/Basic/AttrDocs.td
Index: clang/include/clang/Basic/AttrDocs.td
===================================================================
--- clang/include/clang/Basic/AttrDocs.td
+++ clang/include/clang/Basic/AttrDocs.td
@@ -2241,7 +2241,10 @@
Clang supports the
``__attribute__((amdgpu_flat_work_group_size(<min>, <max>)))`` attribute for the
AMDGPU target. This attribute may be attached to a kernel function definition
-and is an optimization hint.
+and is an optimization hint. It is mandatory to use this attribute in some
+situations. Because when the attribute is absent, the compiler assumes the
+default maximum workgroup size of 256 but nowadays the workgroup size can legally go
+to 1024.
``<min>`` parameter specifies the minimum flat work-group size, and ``<max>``
parameter specifies the maximum flat work-group size (must be greater than
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102134.343920.patch
Type: text/x-patch
Size: 840 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210509/eb77754c/attachment-0001.bin>
More information about the cfe-commits
mailing list