[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

[PoojaYadav via Phabricator via cfe-commits]

pooja2299 created this revision.
pooja2299 added a reviewer: xgupta.
Herald added a subscriber: tpr.
Herald added a reviewer: aaron.ballman.
pooja2299 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Changed the documentation of amdgpu_flat_work_group_size under AMD GPU Attributes which suggested that attribute is an optimization hint. But as suggested in the bug https://bugs.llvm.org/show_bug.cgi?id=42989, it should be made mandatory.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102134

Files:
  clang/include/clang/Basic/AttrDocs.td


Index: clang/include/clang/Basic/AttrDocs.td
===================================================================
--- clang/include/clang/Basic/AttrDocs.td
+++ clang/include/clang/Basic/AttrDocs.td
@@ -2240,8 +2240,8 @@
 
 Clang supports the
 ``__attribute__((amdgpu_flat_work_group_size(<min>, <max>)))`` attribute for the
-AMDGPU target. This attribute may be attached to a kernel function definition
-and is an optimization hint.
+AMDGPU target. This attribute can be attached to a kernel function definition
+and is mandatory in some situations.
 
 ``<min>`` parameter specifies the minimum flat work-group size, and ``<max>``
 parameter specifies the maximum flat work-group size (must be greater than


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102134.343917.patch
Type: text/x-patch
Size: 706 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210509/3d83293e/attachment.bin>