[PATCH] D95745: Support unwinding from inline assembly

[Paul via Phabricator via cfe-commits]

cynecx added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:2446
+    if (!IA->canThrow()) {
+      // Fast path without emitting EH_LABELs.
+
----------------
Amanieu wrote:
> Is this fast path actually useful? The frontend will almost never emit an invoke instruction for inline asm that can't unwind.
This is just an optimization so that we don't emit unwind information since the inline asm doesn't "throw" and also matches the old/new SelectionDAG behavior. Either way I don't really mind removing this but I'd personally keep this for consistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95745/new/

https://reviews.llvm.org/D95745