[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 7 19:57:50 PDT 2021


TaoPan added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:275-276
+      return createFastDAGScheduler(IS, OptLevel);
+    if (TLI->getSchedulingPreference() == Sched::Linearize)
+      return createDAGLinearizer(IS, OptLevel);
     assert(TLI->getSchedulingPreference() == Sched::ILP &&
----------------
pengfei wrote:
> Can this be omitted given `createFastDAGScheduler` should make it linked.
For making scheduler fast and linearize visible by clang -pre-RA-sched, yes, createDAGLinearizer can be omitted.
Adding both is also for keeping the ability that all schedulers can be selected by TargetLowering object in the case of clang -pre-RA-sched=default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101601/new/

https://reviews.llvm.org/D101601



More information about the cfe-commits mailing list