[PATCH] D102065: [AMDGPU][OpenMP] Emit textual IR for -emit-llvm -S

[Pushpinder Singh via Phabricator via cfe-commits]

pdhaliwal added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4397
                JA.getType() == types::TY_LTO_BC) {
-      CmdArgs.push_back("-emit-llvm-bc");
+      // Emit textual llvm IR for AMDGPU offloading for -emit-llvm -S
+      if (Triple.isAMDGCN() && IsOpenMPDevice) {
----------------
JonChesterfield wrote:
> Does unconditionally using emit-llvm here achieve the same result?
Nope, it would start producing textual IR even when there was no -emit-llvm -S. This could be problematic since we always have been producing .bc files including our libraries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102065/new/

https://reviews.llvm.org/D102065