[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 7 05:07:54 PDT 2021


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/lib/Basic/Targets/PPC.cpp:359
       llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) {
-    // We have __float128 on PPC but not power 9 and above.
+    // We have __float128 on PPC but not pre-VSX targets and above.
     Diags.Report(diag::err_opt_not_valid_with_opt) << "-mfloat128" << CPU;
----------------
Nit: remove `and above`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92815/new/

https://reviews.llvm.org/D92815



More information about the cfe-commits mailing list