[PATCH] D101785: [clangd][ObjC] Highlight Objc Ivar refs
David Goldman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 6 07:54:10 PDT 2021
dgoldman added a comment.
In D101785#2741535 <https://reviews.llvm.org/D101785#2741535>, @kadircet wrote:
> Thanks! Can you also add a test to `FindExplicitReferencesTest.All` ? as that's where the underlying change lies.
>
> To disambiguate properties and ivars, what if we used modifiers? I suppose we can mark properties with `abstract` modifier, but i am not an obj-c person so it might be better for you to vet such an idea.
Done. I don't think a modifier would make sense though - they're not really abstract. I think it would be better if there was a Field token type, like the Field symbol kind.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101785/new/
https://reviews.llvm.org/D101785
More information about the cfe-commits
mailing list