[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

David Spickett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 6 06:50:15 PDT 2021


DavidSpickett added a comment.

The failing test line is:

  // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10

It passes if you have the X86 backend enabled but fails if you do not. Our bots usually have only Arm or AArch64 enabled.

When you have the X86 backend:

  ; Function Attrs: nofree norecurse nosync nounwind mustprogress
  define void @_Z14static_chunkedPfS_S_S_(float* nocapture %a, float* nocapture readonly %b, float* nocapture readonly %c, float* nocapture readonly %d) local_unnamed_addr #1 {
  entry:
    %arrayidx.0 = getelementptr inbounds float, float* %b, i64 131071
    %arrayidx2.0 = getelementptr inbounds float, float* %c, i64 131071
    %arrayidx4.0 = getelementptr inbounds float, float* %d, i64 131071
    %arrayidx7.0 = getelementptr inbounds float, float* %a, i64 131071
    %indvars.iv.next.0 = add nuw nsw i64 131071, 127
    br label %for.body
  
  for.cond.cleanup:                                 ; preds = %for.body
    ret void

When you don't:

  ; Function Attrs: nofree norecurse nosync nounwind mustprogress
  define void @_Z14static_chunkedPfS_S_S_(float* nocapture %a, float* nocapture readonly %b, float* nocapture readonly %c, float* nocapture readonly %d) local_unnamed_addr #1 {
  entry:
    br label %for.body
  
  for.cond.cleanup:                                 ; preds = %for.body
    ret void

This is one of a few differences, I'll see if I can post a diff in a way that makes sense to read.

Either way this seems like a bug given that clang usually doesn't require the llvm backend for a particular target. (which is why things like the target parser are always enabled) But I'm new to OpenMP so please correct me if not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101849/new/

https://reviews.llvm.org/D101849



More information about the cfe-commits mailing list