[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL
Alexey Bataev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 6 04:37:09 PDT 2021
ABataev added inline comments.
================
Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu:65-68
+ asm volatile("barrier.sync %0;"
+ :
+ : "r"(barrier)
+ : "memory");
----------------
Why not `__syncthreads`? It is safer to use `__syncthreads` as it is `convergent`. Would be good to mark this code somehow as `convergent` too to avoid incorrect optimizations
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101976/new/
https://reviews.llvm.org/D101976
More information about the cfe-commits
mailing list