[PATCH] D101462: [MC] Untangle MCContext and MCObjectFileInfo

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 5 10:04:23 PDT 2021


MaskRay added a comment.

In D101462#2733726 <https://reviews.llvm.org/D101462#2733726>, @flip1995 wrote:

>> I'll keep this open for a few days as it touches too many things.
>
> Sounds good 👍
>
>> but you'll need to provide your name and email
>
> ~~I used `arc diff`. The commits I made with `git` have my name and email attached. But it seems like `arc` doesn't use them? I'll figure it out tomorrow, can't be that hard, I hope.~~
>
> Ah you just need that to commit it. In that case: "Philipp Krones <philipp.krones at embecosm.com>"

Pushed:) You are right. A diff applied with `arc diff` can be fetched locally with `arc patch D101462` with the author information.
(Sometimes `arc patch` fail refuse to apply and then I'll have no idea how to get the author information.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101462/new/

https://reviews.llvm.org/D101462



More information about the cfe-commits mailing list