[PATCH] D101608: [WebAssembly] Support for WebAssembly globals in LLVM IR

Andy Wingo via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 6 03:22:28 PDT 2021


wingo marked an inline comment as done.
wingo added a comment.

Thanks for the review!

Regarding the address space name -- the intention with "object" was to rhyme a bit with "object capabilities", somehow, but I see that it is confusing.

How about `WASM_ADDRESS_SPACE_MANAGED` ?  I.e. this address space is for "managed" variables.  Doesn't mean that the variables are under GC control (though they may be), but rather that the wasm implementation manages their storage itself, instead of having them be in linear memory.  Will post a renamed patch, lmk what you think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101608/new/

https://reviews.llvm.org/D101608



More information about the cfe-commits mailing list