[PATCH] D100625: [clang-tools-extra] Do not use `LLVM_EXTERNAL_CLANG_TOOLS_EXTRA_SOURCE_DIR`

Thu May 6 01:51:53 PDT 2021

Abpostelnicu abandoned this revision.
Abpostelnicu added a comment.

In D100625#2741385 <https://reviews.llvm.org/D100625#2741385>, @hvdijk wrote:

> Apparently Phabricator detected the presence of "revert D100625 <https://reviews.llvm.org/D100625>" in my alternative D101851 <https://reviews.llvm.org/D101851>'s description and marked that as reverting this one. Of course, as this hadn't been committed, it cannot have been reverted either. Could you confirm that things work for you now, @Abpostelnicu?
>
> In D100625#2697345 <https://reviews.llvm.org/D100625#2697345>, @jpalus wrote:
>
>> Do you mind taking a look at fix proposed in:
>>
>> https://bugs.llvm.org/show_bug.cgi?id=49990#c3
>
> Sorry for not noticing this before, this is pretty much what I came up with too and what's committed now.

It works just fine, thank you.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100625/new/

https://reviews.llvm.org/D100625