[PATCH] D101960: [openmp] Drop requirement on library path environment variables

Thu May 6 00:41:50 PDT 2021

lebedev.ri added a comment.

Thank you for looking into this!
This also fixes the problem of not being able to find `libomp`, right?

================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:648

+void tools::addOpenMPRuntimeSpecificRPath(const ToolChain &TC,
+                                          const ArgList &Args,
----------------
JonChesterfield wrote:
> Similar to other functions in this file, derived from aomp (by deleting some stuff for finding a debug version of the library)
> 
> I can make my peace with runpath instead if people are keen to override this with LD_LIBRARY_PATH. The rest of clang's toolchains wire things up with rpath but that doesn't mean we have to make the same choice here.
I think it would be a shame if this would be the only thing
that *doesn't* support being overriden with `LD_LIBRARY_PATH`.
I'm not sure about `libomptarget`, but it i think it would be good to keep such possibility for `libomp`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101960/new/

https://reviews.llvm.org/D101960