[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 5 06:29:19 PDT 2021


njames93 added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-vararg-ms.cpp:7
+
+// RUN: %check_clang_tidy %s cppcoreguidelines-pro-type-vararg %t
+
----------------
TWeaver wrote:
> Is the missing FileCheck call here on purpose? it seems to me that the CHECK-MESSAGES aren't actually being verified by this test?
> 
> unless I'm missing something.
> 
> TIA
`check_clang_tidy` invokes FileCheck. Does something else make you think these labels are being tested?? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101259/new/

https://reviews.llvm.org/D101259



More information about the cfe-commits mailing list