[PATCH] D101901: [AMDGPU][OpenMP] Fix clang driver crash when provided -c

[Jon Chesterfield via Phabricator via cfe-commits]

JonChesterfield added a comment.

@jdoerfert This drops the logic for save-temps that I remember being contentious.

Doing a no-op backend pass instead of skipping over it is probably more robust.



================
Comment at: clang/lib/Driver/Driver.cpp:4600
+
+      if (const AssembleJobAction *AA = dyn_cast<AssembleJobAction>(A)) {
+        return BuildJobsForAction(C, *AA->input_begin(), TC, BoundArch,
----------------
I wonder if this would be clearer as if (isa<>() || isa<>()) followed by a ternary to pick the second argument to BuildJobs. Overall I think I prefer the separate calls, as currently written.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101901/new/

https://reviews.llvm.org/D101901