[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use
Eric Christopher via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 4 15:14:09 PDT 2021
echristo added inline comments.
================
Comment at: clang/test/Frontend/invalid-cxx-abi.cpp:1
+// These should succeed.
+// RUN: %clang -c -fc++-abi=itanium %s
----------------
Following up on an offline conversation :)
This should be a driver test rather than (what it ended up being) as a full end to end test including code generation. You'll just want to check that the clang command line is handled and translated, etc. It'll also let you keep some of the more elaborate target triples that ended up being removed. Note that the cc1 tests are also doing this so need to be changed as well.
I'd probably also suggest removing the not clang ones and putting those into a different file, but that's largely stylistic.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85802/new/
https://reviews.llvm.org/D85802
More information about the cfe-commits
mailing list