[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.

Dan Liew via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 4 11:21:05 PDT 2021


delcypher marked an inline comment as done.
delcypher added inline comments.


================
Comment at: clang/lib/Driver/ToolChain.cpp:408
   default:
     return getOS();
   }
----------------
arphaman wrote:
> It might be cleaner to do a check for `isOSDarwin` here, as that will help with any other Darwin platforms that we need to support.
@arphaman That seems like a good idea. I didn't know this API existed. I'll try to switch to that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101682/new/

https://reviews.llvm.org/D101682



More information about the cfe-commits mailing list