[PATCH] D101682: [Driver] Fix `ToolChain::getCompilerRTPath()` to return the correct path on Apple platforms.
Alex Lorenz via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 4 09:05:46 PDT 2021
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, the only suggestion I have is below.
================
Comment at: clang/lib/Driver/ToolChain.cpp:408
default:
return getOS();
}
----------------
It might be cleaner to do a check for `isOSDarwin` here, as that will help with any other Darwin platforms that we need to support.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101682/new/
https://reviews.llvm.org/D101682
More information about the cfe-commits
mailing list