[PATCH] D101790: [clang-tidy] Aliasing: Add support for passing the variable into a function by reference.

[Balogh, Ádám via Phabricator via cfe-commits]

baloghadamsoftware added a comment.

In D101790#2734937 <https://reviews.llvm.org/D101790#2734937>, @NoQ wrote:

> +Adam, the original author of bugprone-redundant-branch-condition. Adam, do you have any thoughts regarding the tests regressed by this patch? Are they something we should absolutely keep warning on?

Actually, this checker did not give any false positives whever I tested it on several open-source projects. I can agree with the one where the function starts another thread which changes its parameter, but the rest, where the local variable is mutated after or in the branch I cannot see any reason to disappear. Can you tell me an example where these are false positives? Why do these warnings disappear?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101790/new/

https://reviews.llvm.org/D101790