[PATCH] D101702: [clang-format] Add more support for C# 8 nullables

Eliza via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 3 12:09:27 PDT 2021


exv added inline comments.


================
Comment at: clang/lib/Format/TokenAnnotator.cpp:3197
+        Right.is(TT_CSharpNullCoalescingAssignment))
+      return true;
+
----------------
MyDeveloperDay wrote:
> should this honour SpaceBeforeAssignmentOperators ?
Good point. Looking more closely, since I have called setKind(tok::equal) on the operator, it seems that the rest of clang-format reliably understands it as an assignment operator and formats it correctly if I don't intervene. I have updated the test case to test this behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101702/new/

https://reviews.llvm.org/D101702



More information about the cfe-commits mailing list