[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

Mon May 3 11:00:31 PDT 2021

nickdesaulniers added a comment.

In D101387#2731436 <https://reviews.llvm.org/D101387#2731436>, @awarzynski wrote:

> In D101387#2730043 <https://reviews.llvm.org/D101387#2730043>, @nickdesaulniers wrote:
>
>> @FarisRehman when I run `llvm-lit -vv flang/test/Driver/fixed-line-length.f90` I see:
>>
>>   UNSUPPORTED: Flang :: Driver/fixed-line-length.f90 (1 of 1)
>>
>> This is with `-DLLVM_ENABLE_PROJECTS="clang;lld;compiler-rt;flang"` used, and a `flang` binary produced.  Does `REQUIRES: new-flang-driver` imply I should be doing something else?
>
> Currently `flang` is just a bash script that's a wrapper for the old driver. The new driver is only enabled conditionally - you have to set `FLANG_BUILD_NEW_DRIVER` to build it. The binary is called `flang-new` (hopefully soon it will be renamed as `flang`).
>
> The changes in Flang LGTM, thanks for working on this!

$ llvm-lit -vv flang/test/Driver/fixed-line-length.f90
PASS: Flang :: Driver/fixed-line-length.f90 (1 of 1)

Nice, thanks for the instructions and info!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101387/new/

https://reviews.llvm.org/D101387