[PATCH] D99543: [clang-tidy] Allow opt-in or out of some commonly occuring patterns in NarrowingConversionsCheck.
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 3 10:48:17 PDT 2021
njames93 added inline comments.
================
Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-ignoreconversionfromtypes-option.cpp:12
+
+typedef long long size_t;
+
----------------
This is breaking tests on windows, It seems like its pre-defined to be `unsigned long long` on windows.
Simplest fix is to rename size_t to something else.
I guess changing the typedef to `unsigned long long` will change behaviour of tests.
Failing that an `// UNSUPPORTED: system-windows` directive at the top of the file would also work.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99543/new/
https://reviews.llvm.org/D99543
More information about the cfe-commits
mailing list