[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 3 08:03:35 PDT 2021


dgoldman marked 2 inline comments as done.
dgoldman added inline comments.


================
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:470
+  if (auto *OT = dyn_cast<ObjCObjectType>(T))
+    return scopeModifier(OT->getInterface());
   return llvm::None;
----------------
kadircet wrote:
> is this guaranteed to be non-null ?
Went ahead and removed it, it's unnecessary now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101554/new/

https://reviews.llvm.org/D101554



More information about the cfe-commits mailing list